clean view generator

lib/generators/scenic/view/templates/db/migrate/update_view.erb

@@ -2,11 +2,11 @@ class <%= migration_class_name %> < <%= activerecord_migration_class %>
   def change
   <%- if materialized? -%>
     update_view <%= formatted_plural_name %>,
-      version: <%= version %>,
-      revert_to_version: <%= previous_version %>,
+      version: <%= definition.version %>,
+      revert_to_version: <%= previous_definition.version %>,
       materialized: <%= no_data? ? "{ no_data: true }" : true %>
   <%- else -%>
-    update_view <%= formatted_plural_name %>, version: <%= version %>, revert_to_version: <%= previous_version %>
+    update_view <%= formatted_plural_name %>, version: <%= definition.version %>, revert_to_version: <%= previous_definition.version %>
   <%- end -%>
   end
 end

lib/generators/scenic/view/view_generator.rb

@@ -30,12 +30,12 @@ def create_migration_file
         if creating_new_view? || destroying_initial_view?
           migration_template(
             "db/migrate/create_view.erb",
-            "db/migrate/create_#{plural_file_name}.rb",
+            "db/migrate/#{migration_class_name.underscore}.rb",
           )
         else
           migration_template(
             "db/migrate/update_view.erb",
-            "db/migrate/update_#{plural_file_name}_to_version_#{version}.rb",
+            "db/migrate/#{migration_class_name.underscore}.rb",
           )
         end
       end
@@ -45,19 +45,11 @@ def self.next_migration_number(dir)
       end
 
       no_tasks do
-        def previous_version
-          @previous_version ||= previous_definition.version
-        end
-
-        def version
-          @version ||= destroying? ? previous_version : previous_version.next
-        end
-
         def migration_class_name
           if creating_new_view?
             "Create#{class_name.tr('.', '').pluralize}"
           else
-            "Update#{class_name.pluralize}ToVersion#{version}"
+            "Update#{class_name.pluralize}ToVersion#{definition.version}"
           end
         end
 
@@ -87,6 +79,8 @@ def creating_new_view?
       end
 
       def definition
+        previous_version = previous_definition.version
+        version = destroying? ? previous_version : previous_version.next
         Scenic::Definition.new(plural_file_name, version)
       end
 
@@ -115,7 +109,7 @@ def create_view_options
       end
 
       def destroying_initial_view?
-        destroying? && version == 1
+        destroying? && definition.version == 1
       end
     end
   end