Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the following query options: "review articles only", "search on a specific language" #512

Closed
wants to merge 2 commits into from

Conversation

amchagas
Copy link

@amchagas amchagas commented Aug 22, 2023

Hi there!
Thanks for setting up Scholarly! We are using if for one of our own projects and after a bit of use, we found the need to add some more features into the query options. Namely, we introduced code to allow users to:

  • Search for review articles only (which translates into "as_rr=1" in the googlescholar URL).
  • search for things in a specific language (which translates to "lang_en" in the googlescholar URL in case searches are done for things in english language).

I did not complete the entire checklist as I was not entirely sure on what would be the best way to do that.. sorry! Happy to work more on it if someone points me in the right direction..

Checklist

  • Check that the base branch is set to develop and not main.
  • Ensure that the documentation will be consistent with the code upon merging.
  • Add a line or a few lines that check the new features added.
  • Ensure that unit tests pass.
    If you don't have a premium proxy, some of the tests will be skipped.
    The tests that are run should pass without raising
    MaxTriesExceededException or other exceptions.

…d also allow users to decide which should be the language of the works being searched
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant