Skip to content

Commit

Permalink
fixed python.edn for CI
Browse files Browse the repository at this point in the history
  • Loading branch information
@daslu
daslu committed Sep 27, 2024
1 parent 2cfebec commit 6bff2c3
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions python.edn
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
{:python-executable "/workspace/anaconda3/bin/python"
:library-path "/workspace/anaconda3/lib/libpython3.10.so.1.0"}

{:python-executable ".venv/bin/python3"}

7 comments on commit 6bff2c3

@behrica
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed ?
There is not "/workspace/anaconda3" directory when running in devcontainer
In my experinece it works better to have an "empty" .venv
directory.
This will make poetry use that dir to create its venv.

@behrica
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have the rendering of the docs as part of the CI build.
That will make things easier, as then this runs in a known environment, always.

What do you run today to re-render the docs ?

@behrica
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the CI error:
Execution error at libpython-clj2.python.info/detect-startup-info (info.clj:92).
Failed to find value python executable. Tried "/workspace/anaconda3/bin/python"

There is something else wrong.
in the devcontainer the venv should be created in .venv and have a python executable in .venv/bin/

As I know there is no anaconda in the devcontainer... It uses "poetry" instead.

I will investigate this.

@behrica
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, you reverted it. I did not pay attention on the "diff".

@daslu
Copy link
Member Author

@daslu daslu commented on 6bff2c3 Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes.

I pushed my python config by mistake, and then realized it broke the CI.

@daslu
Copy link
Member Author

@daslu daslu commented on 6bff2c3 Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have the rendering of the docs as part of the CI build.
That will make things easier, as then this runs in a known environment, always.

What do you run today to re-render the docs ?

@behrica
Thanks, let us discuss this as a separate topic (Issue or Zulip)?

@daslu
Copy link
Member Author

@daslu daslu commented on 6bff2c3 Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see the other discussion now, thanks.
#33

Please sign in to comment.