327 browse all wares #328
Merged
327 browse all wares #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the default api setting is to return 25 wares per page. so, we were only returning 25 wares total on the browse page. we now are returning "all" wares by choosing to get 2000 wares per page in the api request. I didn't see a way to set `page: "all"` or `per_page: "all"`. if a marketplace has more than 2000 wares, we will need to increase the number.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
labradford
reviewed
Nov 30, 2023
| @@ -127,6 +127,8 @@ export const FEATURED_SERVICE_PATH = '/requests/new' | |||
| // the default is 1 week | |||
| export const EXPIRATION_DURATION = 604800000 | |||
|
|
|||
| export const API_PER_PAGE = 2000 | |||
There was a problem hiding this comment.
Do you actually load them all on the page at once? Or is there some kind of infinite scroll or pagination?
There was a problem hiding this comment.
it's an infinite scroll. there's a video in the pr comment if that helps. doesn't seem to be problematic. but also....the beachsidebiotech and phenovista marketplaces each have under 600 wares. I went with 2000 for insurance with other marketplaces.
and in the next phase, or with the next client, we may introduce pagination.
labradford
approved these changes
Nov 30, 2023
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return all wares for the given marketplace
the default api setting is to return 25 wares per page. so, we were only returning 25 wares total on the browse page. we now are returning "all" wares by choosing to get 2000 wares per page in the api request. I didn't see a way to set
page: "all"orper_page: "all".if a marketplace has more than 2000 wares, we will need to increase the number.
Screenshots / Video
postman api call
Screen.Recording.2023-11-30.at.02.11.08.PM.mp4