-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
360-fix-e2e-specs #371
Open
DaltonMcauliffe
wants to merge
30
commits into
main
Choose a base branch
from
360-fix-e2e-specs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
360-fix-e2e-specs #371
+87
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we're importing the waresFixture so that we can, access the new request page as an unauthorized user. - ref: #360 Co-authored-by: alisha evans <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
update the spec to account for the "new request" flow as an authorized and unauthorized user. left TODO's for dalton, adrian and jean to pick up when they return to this work.
Co-authored-by: Alisha Evans <[email protected]>
the intercept command was not ever working. now, we are expecting to use the real api calls instead of mocked ones. this is to ensure that our critical paths of browsing and creating a request are always working, even when the api is updated. I also refactored part of the browse page specs into the home page spec, since that's the flow it was actually testing. also edited the cypress config to make it more dynamic, which will help with this code existing in the various client codebases.
1 task
there may potentially be hundreds of services on a page. to avoid a timeout, we will only choose from 10 services. this still ensures that a variety of dynamic forms are tested
Co-authored-by: Dalton Mcauliffe <[email protected]> Co-authored-by: Adrian Carranza <[email protected]>
…serv/webstore into 360-fix-e2e-specs
Co-authored-by: DaltonMcauliffe <[email protected]> Co-authored-by: Adrian Carranza <[email protected]>
loading a full browse page can take a while. the beachside biotech provider has 585 services and we're loading them all at once. certain services also have more complex dynamic forms, which could mean it takes longer for them to load. increasing the timeout for both operations prevents a failure due to time, opposed to assertion.
attempt to get around long timeouts by waiting for an expected element to be on the page before continuing
when running specs locally with "cypress open" (headed), they pass. they fail locally when running "cypress run"(headless) for timeout issues. ci also runs headless, and gets timeout issues. I'm updating the config to run headed in ci in an attempt to get them to pass. ref: cypress-io/github-action#403 (comment)
alishaevn
had a problem deploying
to
Production
February 13, 2024 00:28
— with
GitHub Actions
Failure
the change in 3479ce0 still erred. I created a new script for the cypress workflow to call specifically. ref: cypress-io/github-action#403 (comment)
alishaevn
had a problem deploying
to
Production
February 13, 2024 00:33
— with
GitHub Actions
Failure
alishaevn
had a problem deploying
to
Production
February 13, 2024 00:40
— with
GitHub Actions
Failure
alishaevn
force-pushed
the
360-fix-e2e-specs
branch
from
February 13, 2024 00:42
bb5c39f
to
bd00f6c
Compare
alishaevn
had a problem deploying
to
Production
February 13, 2024 00:42
— with
GitHub Actions
Failure
Draft
Merged
also wait for more elements to appear on the page before running assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
story
fix the broken browse tests locally. they will still fail in ci due to configuration. (ref: #378)
Co-authored-by: Adrian Carranza [email protected]
Co-authored-by:Jean Aragon [email protected]
Co-authored-by: Alisha Evans [email protected]
Screenshots / Video
Testing
env
property of "cypress.config.js" set up.yarn cypress:e2e
notes
if you see an error like the below, it is not because of the test but of another issue that will be handled separately as it has to do with some dynamic forms not being created properly. (this issue should only affect the beachside marketplace, not phenovista. ref: #376)
error