-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
361 fix home specs #373
Merged
Merged
361 fix home specs #373
Commits on Feb 8, 2024
-
correct the customApiIntercept
loading
case`req.reply()` was not returning an empty response, it was returning the actual response from the server. this led to the "loading" state being present momentarily before the actual response was returned. we are now forcing the loading state to remain, as the mock intends.
Configuration menu - View commit details
-
Copy full SHA for 7c7ea59 - Browse repository at this point
Copy the full SHA 7c7ea59View commit details -
made the cypress config file more dynamic. it also will allow us to correctly intercept api calls in our `customApiIntercept` command. update the "featured services list is loading" test check that we in fact have 3 placeholder items, as the description states.
Configuration menu - View commit details
-
Copy full SHA for f9d4eae - Browse repository at this point
Copy the full SHA f9d4eaeView commit details -
changed up the specs to fit the flow of the home page. also moving two specs from the browse page to the home page since that's where the requests originate from.
Configuration menu - View commit details
-
Copy full SHA for 940b731 - Browse repository at this point
Copy the full SHA 940b731View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4111930 - Browse repository at this point
Copy the full SHA 4111930View commit details -
Configuration menu - View commit details
-
Copy full SHA for 733458a - Browse repository at this point
Copy the full SHA 733458aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 531182c - Browse repository at this point
Copy the full SHA 531182cView commit details
Commits on Feb 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9c7f21f - Browse repository at this point
Copy the full SHA 9c7f21fView commit details
Commits on Feb 12, 2024
-
properly throw errors from fetcher
although we were catching the error in `#fetcher`, we weren't returning it as an error. it was being returned to the caller as the `data` value. this means none of our `isError` checks for GET requests were working properly. with this commit, we're throwing the error so that we are handling it on the view correctly.
Configuration menu - View commit details
-
Copy full SHA for 6113560 - Browse repository at this point
Copy the full SHA 6113560View commit details -
correctly accounting for errors on the home page spec
we're testing for an invalid access token now. the `customApiIntercept` command is also simplified.
Configuration menu - View commit details
-
Copy full SHA for fd52f07 - Browse repository at this point
Copy the full SHA fd52f07View commit details -
also further simplified the `customApiIntercept` function.
Configuration menu - View commit details
-
Copy full SHA for 808b838 - Browse repository at this point
Copy the full SHA 808b838View commit details
Commits on Feb 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 11f0bc9 - Browse repository at this point
Copy the full SHA 11f0bc9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.