Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

361 fix home specs #373

Merged
merged 11 commits into from
Feb 14, 2024
Merged

361 fix home specs #373

merged 11 commits into from
Feb 14, 2024

Commits on Feb 8, 2024

  1. correct the customApiIntercept loading case

    `req.reply()` was not returning an empty response, it was returning the
    actual response from the server. this led to the "loading" state being
    present momentarily before the actual response was returned. we are now
    forcing the loading state to remain, as the mock intends.
    alishaevn committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    7c7ea59 View commit details
    Browse the repository at this point in the history
  2. fix the first home spec

    made the cypress config file more dynamic. it also will allow us to
    correctly intercept api calls in our `customApiIntercept` command.
    
    update the "featured services list is loading" test check that we in
    fact have 3 placeholder items, as the description states.
    alishaevn committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f9d4eae View commit details
    Browse the repository at this point in the history
  3. refactor the home page specs

    changed up the specs to fit the flow of the home page. also moving two
    specs from the browse page to the home page since that's where the
    requests originate from.
    alishaevn committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    940b731 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4111930 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    733458a View commit details
    Browse the repository at this point in the history
  6. formatting

    alishaevn committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    531182c View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    9c7f21f View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. properly throw errors from fetcher

    although we were catching the error in `#fetcher`, we weren't returning
    it as an error. it was being returned to the caller as the `data` value.
    this means none of our `isError` checks for GET requests were working
    properly.
    with this commit, we're throwing the error so that we are handling it
    on the view correctly.
    alishaevn committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    6113560 View commit details
    Browse the repository at this point in the history
  2. correctly accounting for errors on the home page spec

    we're testing for an invalid access token now.
    the `customApiIntercept` command is also simplified.
    alishaevn committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    fd52f07 View commit details
    Browse the repository at this point in the history
  3. all 7 home specs are passing

    also further simplified the `customApiIntercept` function.
    alishaevn committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    808b838 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. remove now irrelevant code

    alishaevn committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    11f0bc9 View commit details
    Browse the repository at this point in the history