Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow int as placeholder array index type #3341

Closed
wants to merge 2 commits into from
Closed

fix: allow int as placeholder array index type #3341

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0b1837
allow int as placeholder array index type
pfackeldey Dec 13, 2024
647ab31
also add indexing with array of integers
pfackeldey Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/awkward/_nplikes/placeholder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from awkward._nplikes.array_like import ArrayLike
from awkward._nplikes.numpy_like import NumpyLike, NumpyMetadata
from awkward._nplikes.shape import ShapeItem, unknown_length
from awkward._regularize import is_array_like
from awkward._typing import TYPE_CHECKING, Any, DType, Self

np = NumpyMetadata.instance()
Expand Down Expand Up @@ -93,6 +94,10 @@ def __getitem__(self, index):
new_length = (stop - start) // step

return type(self)(self._nplike, (new_length,), self._dtype)
elif isinstance(index, int):
return type(self)(self._nplike, (1,), self._dtype)
elif is_array_like(index) and np.issubdtype(index.dtype, np.integer):
return type(self)(self._nplike, index.shape, self._dtype)
else:
raise TypeError(
f"{type(self).__name__} supports only trivial slices, not {type(index).__name__}"
Expand Down
Loading