feat: Cleanup internal names for hypotest #1247
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
|
||
| def teststatistic(self, poi_test): | ||
| raise RuntimeError('need to call .teststatistic first') | ||
| distribution_alt = AsymptoticTestStatDistribution(-self.sqrtqmuA_v) |
There was a problem hiding this comment.
signal + background in exclusion fit is the null
| CLsb = sig_plus_bkg_distribution.pvalue(teststat) | ||
| CLb = b_only_distribution.pvalue(teststat) | ||
| CLs = CLsb / CLb | ||
| pvalue_alt = alt_distribution.pvalue(teststat) |
matthewfeickert
force-pushed
the
feat/discoveryTestStat
branch
from
41eda33
to
1f64782
Compare
kratsg
force-pushed
the
feat/cleanupHypotestInternalNames
branch
from
3c45f1d
to
eeb35c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please first read CONTRIBUTING.md.
Please describe the purpose of this pull request in some detail. Reference and link to any relevant issues or pull requests.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: