-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Use context managers to avoid <_io.FileIO [closed]> warnings #1784
Draft
matthewfeickert
wants to merge
11
commits into
main
Choose a base branch
from
test/use-context-manager
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
matthewfeickert
added
the
chore
Other changes that don't modify src or test files
label
Feb 19, 2022
matthewfeickert
force-pushed
the
test/use-context-manager
branch
2 times, most recently
from
September 15, 2022 04:30
8b3f952
to
bcebcc0
Compare
Additional context managers still needed in |
matthewfeickert
force-pushed
the
test/use-context-manager
branch
from
September 25, 2022 07:48
bcebcc0
to
2c3ddb9
Compare
matthewfeickert
force-pushed
the
test/use-context-manager
branch
from
December 4, 2022 00:36
2c3ddb9
to
058ce0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1776
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: