Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CI actions and add Dependabot #142

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

ariostas
Copy link
Collaborator

@ariostas ariostas commented Mar 5, 2024

The version of the actions that were used in the CI were very old and needed to be updated. I changed them all to their latest version, and I added a dependabot.yml file to keep them up to date.

Also, removed Python 3.7 from being tested since it seems to be causing some trouble (see e.g. #141). I added testing of Python 3.11 and 3.12. It would probably make sense to officially drop support for Python 3.7 soon since it has reached its end of life.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@9ed1610). Click here to learn what that means.

❗ Current head cfa2d55 differs from pull request most recent head 97ecd70. Consider uploading reports for the commit 97ecd70 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage        ?   69.78%           
=======================================
  Files           ?        3           
  Lines           ?      139           
  Branches        ?        0           
=======================================
  Hits            ?       97           
  Misses          ?       42           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, especially for the point of dropping old Pythons and adding new ones.

(The repo probably only needs to be tested on the minimum and maximum Python version. It's pure Python and doesn't have much functionality—mostly, it's a collection of raw files.)

@ariostas
Copy link
Collaborator Author

ariostas commented Mar 5, 2024

The repo probably only needs to be tested on the minimum and maximum Python version

Yeah, that's true. I'll change it.

@jpivarski jpivarski enabled auto-merge (squash) March 21, 2024 16:15
@jpivarski jpivarski merged commit 48f4681 into scikit-hep:main Mar 21, 2024
4 checks passed
@ariostas ariostas deleted the ci_updates branch April 17, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants