Dps management

[EmmaRenauld]

Started adding tests

• Changed dps from an arg in the script (--dps_keys) to a line in the config file. This works.
• Copied the file streamline_containers from Jeremi's PR and started testing. Does not seem to work yet. Need to check the data shape. Work to be continued.

[levje]

Not to forget: maybe worth adding tests for 2D data_per_streamline arrays before merging.

[levje]

Sidenote: with DPS management, the test HDF5 will have the following structure:

[pep8speaks]

Hello @EmmaRenauld, Thank you for updating !

• In the file dwi_ml/data/dataset/streamline_containers.py:

Line 377:80: E501 line too long (80 > 79 characters)
Line 433:80: E501 line too long (80 > 79 characters)

Comment last updated at 2024-11-07 21:42:39 UTC

[EmmaRenauld]

Looks ok. Did you manage to test with 2D data? I would do that before merging.

[levje]

I did manage to get some tests in the PR in test_dataset.py to make sure the mock_2d_dps is the same as expected. I caught a few errors which those tests which are already fixed. Should I write more tests for 2d data?

[EmmaRenauld]

No it's ok for now! Let's go forward! Merging