Merge pull request #20 from scipopt/issue-19-narrowing-constant-linea…

…r-expressions Allow the construction of constant linear expressions without narrowing warnings
scipopt · Nov 22, 2023 · 066d898 · 066d898
2 parents 004fac8 + 4baa55e
commit 066d898
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/include/scippp/lin_expr.hpp b/include/scippp/lin_expr.hpp
@@ -29,9 +29,15 @@ class LinExpr {
      * Creates a linear expression with no variables.
      * @since 1.0.0
      * @remark This is on purpose not an explicit c'tor to allow expressions like x <= 1.
+     * @tparam Arithmetic type that will be casted to \c double.
+     * @warning \c Arithmetic is casted to \c double without creating a narrowing warning!
      * @param constant Constant term to set.
      */
-    LinExpr(double constant);
+    template <typename Arithmetic, std::enable_if_t<std::is_arithmetic_v<Arithmetic>, bool> = true>
+    LinExpr(Arithmetic constant)
+        : m_constant { static_cast<double>(constant) }
+    {
+    }
     /**
      * Creates a linear expression with zero as constant the given variable with coefficient one.
      * @since 1.0.0

diff --git a/source/lin_expr.cpp b/source/lin_expr.cpp
@@ -2,11 +2,6 @@
 
 namespace scippp {
 
-LinExpr::LinExpr(double constant)
-    : m_constant { constant }
-{
-}
-
 LinExpr::LinExpr(const Var& var)
     : m_vars { var }
     , m_coeffs(1, 1)