Skip to content

Commit

Permalink
Merge branch 'v9-minor'
Browse files Browse the repository at this point in the history
  • Loading branch information
svigerske committed Feb 28, 2024
2 parents c6ccb40 + 1ca110f commit 4126855
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 0 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,18 @@ Fixed bugs
----------

- fixed bug in detection of double lex matrices due to wrong memory allocation
- fixed bug where parameter `limits/objectivestop` was copied to subscips in plugins which have different objectives


Miscellaneous
-------------

Build system
------------

### Cmake

- removed replacement of the settings of RelWithDebInfo


@section RN900 SCIP 9.0.0
Expand Down
1 change: 1 addition & 0 deletions pclint/scip.lnt
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@
// is likely uninitialized
-emacro(530,va_*)
-ecall(530,vsnprintf)
-emacro(530,SCIPalloc*)

// ignoring return value of function
-esym(534,printf,fprintf,fclose,fputs,fputc,fseek,fflush,strcat,strcpy,SCIPfclose,SCIPfseek,memset,memcpy,memmove)
Expand Down
1 change: 1 addition & 0 deletions src/scip/cons_components.c
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,7 @@ SCIP_RETCODE createSubscip(
/* disable solution limits */
SCIP_CALL( SCIPsetIntParam(*subscip, "limits/solutions", -1) );
SCIP_CALL( SCIPsetIntParam(*subscip, "limits/bestsol", -1) );
SCIP_CALL( SCIPresetParam(*subscip, "limits/objectivestop") );

/* reduce the effort spent for hash tables; however, if the debug solution is enabled and valid in this subtree,
* hash tables are needed for installing the debug solution
Expand Down
3 changes: 3 additions & 0 deletions src/scip/heur_dualval.c
Original file line number Diff line number Diff line change
Expand Up @@ -971,6 +971,9 @@ SCIP_RETCODE createSubSCIP(
/* copy parameter settings */
SCIP_CALL( SCIPcopyParamSettings(scip, heurdata->subscip) );

/* disable objective stop in subscip */
SCIP_CALL( SCIPresetParam(heurdata->subscip, "limits/objectivestop") );

/* create problem in sub-SCIP */

/* get name of the original problem and add "dualval" */
Expand Down
2 changes: 2 additions & 0 deletions src/scip/heur_lpface.c
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,8 @@ SCIP_RETCODE setSubscipLimits(
/* set also the other two limits */
SCIP_CALL( SCIPsetRealParam(subscip, "limits/time", timelimit) );
SCIP_CALL( SCIPsetRealParam(subscip, "limits/memory", memorylimit) );
/* disable objective stop */
SCIP_CALL( SCIPresetParam(subscip, "limits/objectivestop") );

return SCIP_OKAY;
}
Expand Down
3 changes: 3 additions & 0 deletions src/scip/heur_repair.c
Original file line number Diff line number Diff line change
Expand Up @@ -940,6 +940,9 @@ SCIP_RETCODE applyRepair(
SCIP_CALL( SCIPsetRealParam(subscip, "limits/memory", memorylimit) );
SCIP_CALL( SCIPsetObjlimit(subscip,1.0) );

/* disable objective stop */
SCIP_CALL( SCIPresetParam(subscip, "limits/objectivestop") );

/* forbid recursive call of heuristics and separators solving sub-SCIPs */
SCIP_CALL( SCIPsetSubscipsOff(subscip, TRUE) );

Expand Down
1 change: 1 addition & 0 deletions src/scip/heur_subnlp.c
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,7 @@ SCIP_RETCODE createSubSCIP(
SCIP_CALL( SCIPresetParam(heurdata->subscip, "limits/solutions") );
SCIP_CALL( SCIPresetParam(heurdata->subscip, "limits/time") );
SCIP_CALL( SCIPresetParam(heurdata->subscip, "limits/totalnodes") );
SCIP_CALL( SCIPresetParam(heurdata->subscip, "limits/objectivestop") );

/* we remember here which way (continuous or not) we went, in case all binary and integer vars get fixed in root */
heurdata->continuous = SCIPgetNBinVars(heurdata->subscip) == 0 && SCIPgetNIntVars(heurdata->subscip) == 0;
Expand Down
3 changes: 3 additions & 0 deletions src/scip/heuristics.c
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,9 @@ SCIP_RETCODE SCIPcopyLargeNeighborhoodSearch(
/* copy parameter settings */
SCIP_CALL( SCIPcopyParamSettings(sourcescip, subscip) );

/* disable objective stop in subscip since objective might be changed */
SCIP_CALL( SCIPresetParam(subscip, "limits/objectivestop") );

/* create linear constraints from LP rows of the source problem */
SCIP_CALL( createRows(sourcescip, subscip, varmap) );
}
Expand Down
1 change: 1 addition & 0 deletions src/scip/scip_copy.c
Original file line number Diff line number Diff line change
Expand Up @@ -3326,6 +3326,7 @@ SCIP_RETCODE SCIPcopyLimits(
SCIP_CALL( SCIPsetIntParam(targetscip, "limits/solutions", -1) );
SCIP_CALL( SCIPsetLongintParam(targetscip, "limits/stallnodes", -1LL) );
SCIP_CALL( SCIPsetLongintParam(targetscip, "limits/totalnodes", -1LL) );
SCIP_CALL( SCIPsetRealParam(targetscip, "limits/objectivestop", SCIP_INVALID) );

return SCIP_OKAY;
}
Expand Down

0 comments on commit 4126855

Please sign in to comment.