-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add pre-commit config #1017
Open
matthewfeickert
wants to merge
4
commits into
scipy-conference:dev
Choose a base branch
from
matthewfeickert:feat/add-pre-commit
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
ci: | ||
autoupdate_commit_msg: "chore: [pre-commit.ci] pre-commit autoupdate" | ||
autoupdate_schedule: quarterly | ||
|
||
repos: | ||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v4.6.0 | ||
hooks: | ||
- id: check-case-conflict | ||
- id: check-json | ||
- id: check-merge-conflict | ||
- id: check-symlinks | ||
- id: check-xml | ||
- id: check-yaml | ||
- id: debug-statements | ||
- id: end-of-file-fixer | ||
exclude: > | ||
(?x)^( | ||
.*\.csv | ||
)$ | ||
- id: mixed-line-ending | ||
exclude: > | ||
(?x)^( | ||
.*\.csv| | ||
.*\.css | ||
)$ | ||
- id: requirements-txt-fixer | ||
- id: trailing-whitespace | ||
exclude: > | ||
(?x)^( | ||
.*\.csv | ||
)$ | ||
|
||
- repo: https://github.com/python-jsonschema/check-jsonschema | ||
rev: 0.29.1 | ||
hooks: | ||
- id: check-github-workflows | ||
args: ["--verbose"] | ||
matthewfeickert marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- repo: https://github.com/pre-commit/mirrors-prettier | ||
rev: v3.1.0 | ||
hooks: | ||
- id: prettier | ||
types_or: [yaml, html, css, scss, javascript, json, toml] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -341,4 +341,3 @@ proceedings editors. | |
:usepackage: somepackage | ||
|
||
Some custom LaTeX source here. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,29 +1,29 @@ | ||
--- | ||
abstract: | ||
- A short version of the long version that is way too long to be written as a short version anyway. Still, when considering the facts from first principles, we find that the outcomes of this introspective approach is compatible with the guidelines previously established. | ||
- In such an experiment it is then clear that the potential for further development not only depends on previous relationships found but also on connections made during exploitation of this novel new experimental protocol. | ||
- A short version of the long version that is way too long to be written as a short version anyway. Still, when considering the facts from first principles, we find that the outcomes of this introspective approach is compatible with the guidelines previously established. | ||
- In such an experiment it is then clear that the potential for further development not only depends on previous relationships found but also on connections made during exploitation of this novel new experimental protocol. | ||
keywords: | ||
- terraforming | ||
- desert | ||
- numerical perspective | ||
authors: | ||
- email: [email protected] | ||
institution: | ||
- Senate House, S.P.Q.R. | ||
- Egyptian Embassy, S.P.Q.R. | ||
name: Gaius Caesar | ||
- email: [email protected] | ||
institution: | ||
- Egyptian Embassy, S.P.Q.R. | ||
name: Mark Anthony | ||
- email: [email protected] | ||
institution: | ||
- Egyptian Embassy, S.P.Q.R. | ||
- Yet another place, S.P.Q.R. | ||
name: Jarrod Millman | ||
corresponding: true | ||
- email: [email protected] | ||
name: Cleopatra | ||
- email: [email protected] | ||
institution: | ||
- Senate House, S.P.Q.R. | ||
- Egyptian Embassy, S.P.Q.R. | ||
name: Gaius Caesar | ||
- email: [email protected] | ||
institution: | ||
- Egyptian Embassy, S.P.Q.R. | ||
name: Mark Anthony | ||
- email: [email protected] | ||
institution: | ||
- Egyptian Embassy, S.P.Q.R. | ||
- Yet another place, S.P.Q.R. | ||
name: Jarrod Millman | ||
corresponding: true | ||
- email: [email protected] | ||
name: Cleopatra | ||
bibliography: mybib | ||
video: "https://www.youtube.com/watch?v=Hz1JWzyvv8A" | ||
title: A Numerical Perspective to Terraforming a Desert -- latex edition | ||
title: A Numerical Perspective to Terraforming a Desert -- latex edition |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
{ | ||
"title": "Introducing JOSE: Journal of Open Source Education", | ||
"authors": [ | ||
{ | ||
"name": "Kyle Niemeyer", | ||
"affiliation": "Oregon State University", | ||
"orcid": "0000-0003-4425-7097" | ||
} | ||
], | ||
"description": "A cool presentation about a cooler open source journal" | ||
"title": "Introducing JOSE: Journal of Open Source Education", | ||
"authors": [ | ||
{ | ||
"name": "Kyle Niemeyer", | ||
"affiliation": "Oregon State University", | ||
"orcid": "0000-0003-4425-7097" | ||
} | ||
], | ||
"description": "A cool presentation about a cooler open source journal" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,16 @@ | ||
{ | ||
"authors": [ | ||
{ | ||
"name": "First Author", | ||
"affiliation": "First Author's Institution", | ||
"orcid": "0101-0101-0101-0103" | ||
}, | ||
{ | ||
"name": "Second Author", | ||
"affiliation": "Second Author's Company", | ||
"orcid": "0202-0211-0101-0141" | ||
} | ||
], | ||
"title": "A test title", | ||
"description": "A brief description of what this object is" | ||
"authors": [ | ||
{ | ||
"name": "First Author", | ||
"affiliation": "First Author's Institution", | ||
"orcid": "0101-0101-0101-0103" | ||
}, | ||
{ | ||
"name": "Second Author", | ||
"affiliation": "Second Author's Company", | ||
"orcid": "0202-0211-0101-0141" | ||
} | ||
], | ||
"title": "A test title", | ||
"description": "A brief description of what this object is" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
{ | ||
"title": "Safe handling instructions for missing data", | ||
"authors": [ | ||
{ | ||
"name": "Dillon Niederhut", | ||
"affiliation": "Enthought, Inc.", | ||
"orcid": "0000-0002-9995-4378" | ||
} | ||
], | ||
"description": "A presentation about what to do with missing data" | ||
"title": "Safe handling instructions for missing data", | ||
"authors": [ | ||
{ | ||
"name": "Dillon Niederhut", | ||
"affiliation": "Enthought, Inc.", | ||
"orcid": "0000-0002-9995-4378" | ||
} | ||
], | ||
"description": "A presentation about what to do with missing data" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
{ | ||
"title": "SciPy Tools Plenary on Mayavi", | ||
"authors": [ | ||
{ | ||
"name": "Prabhu Ramachandran", | ||
"affiliation": "Department of Aerospace Engineering, IIT, Bombay", | ||
"orcid": "0000-0001-6337-1720" | ||
} | ||
], | ||
"description": "2018 updates in Mayavi, a 3D plotting application" | ||
"title": "SciPy Tools Plenary on Mayavi", | ||
"authors": [ | ||
{ | ||
"name": "Prabhu Ramachandran", | ||
"affiliation": "Department of Aerospace Engineering, IIT, Bombay", | ||
"orcid": "0000-0001-6337-1720" | ||
} | ||
], | ||
"description": "2018 updates in Mayavi, a 3D plotting application" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would also benefit from codespell-project/codespell being added (c.f. https://github.com/scipy-conference/scipy-conference/blob/3755b74eb94a00ca7038b5210f01f021b5127e72/.pre-commit-config.yaml#L30-L38) but given that there are multiple words that need to get added to an ignore list and fixed in files, I've decided to not do that in this PR. as it would need some input from other parties.