Refactored and added discarding logic #45
Conversation
mery25
commented
Oct 3, 2018
mery25
commented
- Separated Exception Handling
- Separate persistence logic to a TweetRepository
- Created PatternExtractor to extract links from Tweet
- Added new endpoints to discard and get discarted tweets. Added logic on Controller, Service and Repository
- Added fields needed on the Tweet entity and created a new Link entity
- Created new test cases
…n Tweet. New test cases
…ed a PatternExtractor to extract the links from the tweet. Added validation annotation on the Tweet fiels to use the Spring VAlidator to validate the fields. Added validation logic on the TweetService. Added new test cases.
…sitory from the TweetService. Solved some bugs. Added some test cases.
…d a ResponseError object
|
(Prospect for FOTOCASA) Whether OK or KO, we'll provide you with constructive feedback. See ya! |
| m.appendReplacement(sb, ""); | ||
| } | ||
| m.appendTail(sb); | ||
| this.text = sb.toString(); |
There was a problem hiding this comment.
Hi, is it a bit strange to let the user of this class the responsability of knowing that he/she has to call the extract method, right? What do you think? How could you do it differently so it is easy to use and the results are inmutable?
There was a problem hiding this comment.
In other words, if text and pattern are always the same, so the extract method always will return the same, what is the point of letting people call it more than once?
There was a problem hiding this comment.
Converted PatternExtractor in a BiFunction that takes a two String and return a PatternExtractorResult
| } | ||
|
|
||
| private String insertLinksOnTweet(String text, List<Link> links) { | ||
| if (links.size() == 0) |
There was a problem hiding this comment.
This code is a bit complex, is it unit tested? Do you think should be in another class maybe?
There was a problem hiding this comment.
Applied same solution than for the PatternExtractor. Created a TextElementInsterter, which is a BiFunction that takes a list of TextElement and a String and returns a String. I have created test cases for TextElementInserter
…racted from Tweet class. Created TextElement and made Link implement from it. Created test cases for TextElementInsterter
