Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Params for spider #120

Merged
merged 4 commits into from
Feb 17, 2021
Merged

Params for spider #120

merged 4 commits into from
Feb 17, 2021

Conversation

pawelmhm
Copy link
Member

@pawelmhm pawelmhm commented Feb 1, 2021 •
edited
Loading

TODO

  • docs
  • add test for returning 400 HTTP code if malformed JSON
  • edge cases

@pawelmhm
Copy link
Member Author

pawelmhm commented Feb 1, 2021

Better solution for #72 #99

@pawelmhm
Copy link
Member Author

docs on other PR.

@pawelmhm pawelmhm merged commit de1f7c3 into master Feb 17, 2021
@pawelmhm pawelmhm deleted the params-for-spider branch February 17, 2021 13:18
@pawelmhm pawelmhm mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pawelmhm