Skip to content

Commit

Permalink
chore: remove pylama/pydocstyle, just use pylint
Browse files Browse the repository at this point in the history
  • Loading branch information
carlmontanari committed Aug 9, 2024
1 parent 63a1b71 commit 9095ffe
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 7 deletions.
5 changes: 3 additions & 2 deletions .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ confidence=HIGH,
# --enable=similarities". If you want to run only the classes checker, but have
# no Warning level messages displayed, use "--disable=all --enable=classes
# --disable=W".
disable=C0103,C0115,R0901,R0902,R0903,R0913,R0914,W1202,W1203
disable=C0103,C0115,R0401,R0801,R0901,R0902,R0903,R0913,R0914,W1202,W1203
# C0103 = constant-name (a little too aggressive for some things that aren't "really" constants")
# C0115 = class docstrings (init doc strings cover this already)
# W1202 = use % formatting for logging (ignore, using f-strings)
Expand All @@ -153,7 +153,8 @@ disable=C0103,C0115,R0901,R0902,R0903,R0913,R0914,W1202,W1203
# R0903 = too-few-public methods
# R0913 = too-many-arguments
# R0914 = too-many-local-variables

# R0801 = similar-lines
# R0401 = cyclic-import (too many false positives, seems like this is a common complaint :p)
# Enable the message, report, category or checker with the given id(s). You can
# either give multiple identifier separated by comma (,) or put this option
# multiple time (only on the command line, not in the configuration file where
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
lint:
python -m isort .
python -m black .
python -m pylama .
python -m pylint scrapli_replay/
python -m pydocstyle .
python -m mypy --strict scrapli_replay/

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ asyncio_mode = "auto"

[tool.pylama]
linters = "mccabe,pycodestyle,pylint"
skip = ".nox/*,.private/*,build/*,docs/*,private/*,site/*,tests/*,venv/*"
skip = ".nox/*,build/*,tests/*,venv/*"

[tool.pylama.pycodestyle]
max_line_length = 100
Expand Down
2 changes: 0 additions & 2 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@ darglint>=1.8.1,<2.0.0
isort>=5.10.1,<6.0.0
mypy>=1.4.1,<2.0.0
nox==2024.4.15
pycodestyle>=2.8.0,<3.0.0
pydocstyle>=6.1.1,<7.0.0
pyfakefs>=5.4.1,<6.0.0
pylama>=8.4.0,<9.0.0
pylint>=3.0.0,<4.0.0
pytest-asyncio>=0.17.0,<1.0.0
pytest-cov>=3.0.0,<5.0.0
Expand Down
2 changes: 1 addition & 1 deletion scrapli_replay/replay/replay.py
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ def __init__(
self.replay_mode = ReplayMode.RECORD

self._block_network = block_network
self._patched_open: Optional[mock._patch[Any]] = None # noqa
self._patched_open: Optional[mock._patch[Any]] = None # pylint: disable=E1136
self.wrapped_instances: Dict[str, ScrapliReplayInstance] = {}

self._channel_close: Optional[Callable[[], None]] = None
Expand Down

0 comments on commit 9095ffe

Please sign in to comment.