Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game.map.describeExits returns null for non-existent rooms #250

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Game.map.describeExits returns null for non-existent rooms #250

merged 3 commits into from
Feb 3, 2024

Conversation

tiennou
Copy link
Contributor

@tiennou tiennou commented Dec 29, 2023

Brief Description

I just had my room-filler crash out because I was too close to the edge on a pserver. Turns out the comment hints about it happening, but the return type doesn't.

Checklists

  • Test passed
  • Coding style (indentation, etc)
  • Edits have been made to src/ files not index.d.ts
  • Run npm run dtslint to update index.d.ts

@DiamondMofeng DiamondMofeng self-requested a review January 6, 2024 01:48
DiamondMofeng
DiamondMofeng approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@DiamondMofeng DiamondMofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DiamondMofeng DiamondMofeng merged commit 1911145 into screepers:master Feb 3, 2024
3 checks passed
@tiennou tiennou deleted the fix/describe-exits branch February 8, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiamondMofeng DiamondMofeng DiamondMofeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiennou @DiamondMofeng