Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting the Order type to ORDER_BUY | ORDER_SELL instead of string #255

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Setting the Order type to ORDER_BUY | ORDER_SELL instead of string #255

merged 3 commits into from
Feb 3, 2024

Conversation

DollarAkshay
Copy link
Contributor

@DollarAkshay DollarAkshay commented Jan 28, 2024 •
edited
Loading

Brief Description

Setting the type to ORDER_BUY | ORDER_SELL instead of string

Checklists

  • Test passed
  • Coding style (indentation, etc)
  • Edits have been made to src/ files not index.d.ts
  • Run npm run dtslint to update index.d.ts

@DollarAkshay
Update Order interface in market.ts
e7a4a25 
Setting the type to ORDER_BUY | ORDER_SELL instead of string
@DollarAkshay
Updating index.d.ts
3bc6e0e
@DollarAkshay
Copy link
Contributor Author

All done. Ready to merge.

@DollarAkshay DollarAkshay changed the title Update Order interface in market.ts Setting the type to ORDER_BUY | ORDER_SELL instead of string Jan 28, 2024
@DollarAkshay DollarAkshay changed the title Setting the type to ORDER_BUY | ORDER_SELL instead of string Setting the Order type to ORDER_BUY | ORDER_SELL instead of string Jan 28, 2024
@DiamondMofeng DiamondMofeng self-requested a review January 29, 2024 00:34
DiamondMofeng
DiamondMofeng approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@DiamondMofeng DiamondMofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DiamondMofeng DiamondMofeng merged commit 8957b7b into screepers:master Feb 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiamondMofeng DiamondMofeng DiamondMofeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DollarAkshay @DiamondMofeng