Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out non-existent binaries. #19

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Comment out non-existent binaries. #19

merged 2 commits into from
Nov 18, 2024

Conversation

yczhangsjtu
Copy link
Collaborator

@yczhangsjtu yczhangsjtu commented Nov 15, 2024 •
edited
Loading

There are two binary source code in profile that are deleted by #17, but the [[bin]] are still in Cargo.toml.

matthiasgoergens
matthiasgoergens requested changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@matthiasgoergens matthiasgoergens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just delete, don't comment out.

@yczhangsjtu yczhangsjtu merged commit 9c2beec into feat/goldilocks-spartan Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasgoergens matthiasgoergens matthiasgoergens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yczhangsjtu @matthiasgoergens