Support remote private storage by consistent use of substore #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 92.53% 92.52% -0.02%
==========================================
Files 43 39 -4
Lines 6003 5270 -733
==========================================
- Hits 5555 4876 -679
+ Misses 448 394 -54
|
writing metadata incrementally
Co-authored-by: Kevin Yamauchi <[email protected]>
…patialdata into feature/incremental_io
* test read write on disk * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * improved tests for workarounds for incremental io * fixed tests * improved comment --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Luca Marconato <[email protected]>
Co-authored-by: Giovanni Palla <[email protected]>
|
for some reason it didn't rebase to main... |
|
hi @berombau seems that there are a lot of conflicts, and still didnt' rebase correctly, not sure what to do but maybe worth to port over the changes to separate PR? |
|
Yeah, I think I switched from merging to rebasing somewhere halfway 😅 I'll try to cherry-pick the changes on a new branch and do a cleaner PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #441, depends on (ome/ome-zarr-py#349)