Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.yaml to use setup-python v4 #509

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

LucaMarconato
Copy link
Member

@LucaMarconato LucaMarconato commented Mar 25, 2024

Using setup-python v4 with pip caching. It should run noticeably faster, let's see.

We may need to upload a second commit to see the caching mechanism in action.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.54%. Comparing base (1f74e77) to head (b84423f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files          43       43           
  Lines        5969     5969           
=======================================
  Hits         5524     5524           
  Misses        445      445           

@LucaMarconato
Copy link
Member Author

LucaMarconato commented Mar 25, 2024

Some stats on the runtimes. Running tests takes around 3-4. I see a lot of variability on the installation of packages (the run that lasted 25min was 22min of packages installation).

  • checkout v4, second run (first run)

    • 3.9, ubuntu-latest: XXX
    • 3.10, ubuntu-latest: XXX
    • 3.9, macos: XXX
    • 3.10, --pre, macos: XXX
  • checkout v4, second run (caching in action)

    • 3.9, ubuntu-latest: XXX
    • 3.10, ubuntu-latest: XXX
    • 3.9, macos: XXX
    • 3.10, --pre, macos: XXX
  • checkout v2, first replicated

    • 3.9, ubuntu-latest: 8m
    • 3.10, ubuntu-latest: 8m
    • 3.9, macos: 7m
    • 3.10, --pre, macos: 11m
  • checkout v2, second replicate

    • 3.9, ubuntu-latest: 7m
    • 3.10, ubuntu-latest: 7m
    • 3.9, macos: 13m
    • 3.10, --pre, macos: 7m
  • checkout v2, third replicate

    • 3.9, ubuntu-latest: 25m
    • 3.10, ubuntu-latest: 8m
    • 3.9, macos: 8m
    • 3.10, --pre, macos: 6m

@LucaMarconato
Copy link
Member Author

I had modified this on build.yaml, not on test_and_deploy.yaml. Now it's fixed.

@LucaMarconato
Copy link
Member Author

LucaMarconato commented Mar 27, 2024

Installing the dependencies seems to be a bit faster, but not consistently faster. Let's this out.

@LucaMarconato LucaMarconato merged commit ece18ea into main Mar 28, 2024
8 checks passed
@LucaMarconato LucaMarconato deleted the setup-python-v4-with-pip-cache branch March 28, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant