Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending get_values() for tables annotating points #537

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

dylanclam12
Copy link
Contributor

Made get_values work for tables that annotate points
Added a check for index dtypes in the element and the table annotating the element.

@LucaMarconato LucaMarconato marked this pull request as ready for review June 14, 2024 10:04
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.11%. Comparing base (3c69b26) to head (65e57bb).
Report is 71 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files          42       42           
  Lines        6469     6471    +2     
=======================================
+ Hits         5959     5961    +2     
  Misses        510      510           
Files with missing lines Coverage Δ
src/spatialdata/_core/query/relational_query.py 90.82% <100.00%> (+0.04%) ⬆️

@LucaMarconato LucaMarconato merged commit 5034933 into scverse:main Jun 14, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants