Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated deprecation_alias #562

Merged
merged 4 commits into from
May 24, 2024
Merged

Conversation

melonora
Copy link
Collaborator

I have updated the deprecation_alias to be flexible enough for implementation across the ecosystems and to handle different arguments with deprecations in different versions.

Example

@deprecation_alias(table="tables", version="version 0.1")
def your_function(tables):
      do something...

your_function(table)

This will now give a message that table is set for deprecation from version 0.1 onwards. The message will also include the library so if a deprecation_alias decorator is applied in a function in spatialdata-plot then it will indicate the spatialdata-plot library in the message.

@timtreis probably useful for the spatialdata-plot refactor.

Copy link
Member

@LucaMarconato LucaMarconato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful!

@LucaMarconato LucaMarconato merged commit bb0c6ac into scverse:main May 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants