Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: citation, relational query index #569

Merged
merged 11 commits into from
May 25, 2024
Merged

fix: citation, relational query index #569

merged 11 commits into from
May 25, 2024

Conversation

LucaMarconato
Copy link
Member

@LucaMarconato LucaMarconato commented May 24, 2024

  • Fixed citation to Nature Methods paper
  • Fixed index of partitioned dataframe for internal API used in the join operations

Skipped:

@LucaMarconato LucaMarconato changed the title fix citation, fix relational query index fix citation, fix relational query index, python 3.12 tests May 24, 2024
@LucaMarconato LucaMarconato changed the title fix citation, fix relational query index, python 3.12 tests fix: citation, relational query index, python 3.12 tests May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.55%. Comparing base (2a38051) to head (dbdbd7f).
Report is 83 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   92.55%   92.55%           
=======================================
  Files          42       42           
  Lines        6001     6003    +2     
=======================================
+ Hits         5554     5556    +2     
  Misses        447      447           
Files Coverage Δ
src/spatialdata/_core/query/relational_query.py 95.51% <100.00%> (+0.02%) ⬆️
src/spatialdata/dataloader/datasets.py 90.68% <ø> (ø)

@LucaMarconato
Copy link
Member Author

We are now testing against the minimum and maximum supported versions of Python: 3.9 and 3.12.

@LucaMarconato
Copy link
Member Author

LucaMarconato commented May 24, 2024

The test fails because of an error in dask that I guess is fixed in the latest version. We should remove the pinning for dask; I'll work on it here: #570.

@LucaMarconato LucaMarconato merged commit 3733514 into main May 25, 2024
8 checks passed
@LucaMarconato LucaMarconato deleted the fixes branch May 25, 2024 13:07
@LucaMarconato LucaMarconato changed the title fix: citation, relational query index, python 3.12 tests fix: citation, relational query index May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant