Substitute e.printStackTrace() with log.error() in some classes

scwlkq · Jan 20, 2024 · bbbf2a4 · bbbf2a4
1 parent 91a49d4
commit bbbf2a4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/eventmesh-common/src/test/java/org/apache/eventmesh/common/ThreadWrapperTest.java b/eventmesh-common/src/test/java/org/apache/eventmesh/common/ThreadWrapperTest.java
@@ -24,6 +24,9 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.Timeout;
 
+import lombok.extern.slf4j.Slf4j;
+
+@Slf4j
 public class ThreadWrapperTest {
 
     @Test
@@ -74,7 +77,7 @@ public void run() {
                 try {
                     TimeUnit.MILLISECONDS.sleep(500);
                 } catch (InterruptedException e) {
-                    e.printStackTrace();
+                    log.error("[ThreadWrapper][shutdown] InterruptedException", e);
                 }
                 counter.set(100);
             }
@@ -136,4 +139,4 @@ public void run() {
         wrapper.setDaemon(daemon);
         return wrapper;
     }
-}
+}
diff --git a/...entmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SourceWorker.java b/...entmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SourceWorker.java
@@ -276,7 +276,6 @@ public void stop() {
         try {
             source.stop();
         } catch (Exception e) {
-            e.printStackTrace();
             log.error("source destroy error", e);
         }
         log.info("pollService stopping");

diff --git a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java
@@ -73,7 +73,7 @@ public void close() {
             task.cancel(false);
             super.close();
         } catch (Exception e) {
-            e.printStackTrace();
+            log.error("PubClientImpl|{}|close|failed", clientNo, e);
         }
     }