-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update theme 1.7 #94
Conversation
cc/ @annastuchlik |
@avelanarius Could you review and merge this PR? |
BTW, this driver is about to be replaced with the newer driver: https://github.com/scylladb/cpp-rust-driver |
@roydahan Thanks for letting us know. The work on that project seems to be suspended. We need to add the docs to that project, just as we did for other projects - but I suggest doing that after the work is resumed. In the meantime, we should continue updating the Sphinx them in this project. @avelanarius Could you review and merge this PR? |
@@ -6,6 +6,7 @@ on: | |||
push: | |||
branches: | |||
- master | |||
- 'branch-**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any such branches in this project so I'm not sure why this change is here.
I guess it doesn't do any harm and we are unlikely to introduce any version branches in this repo, so it can stay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, we aimed to use the same file across repositories, but it's fine to remove this line for this project.
- 'branch-**' |
@avelanarius Can you merge this PR? It has been reviewed and approved. |
Related issue scylladb/sphinx-scylladb-theme#1035
ScyllaDB Sphinx Theme 1.7 is out 🥳 Now, the docs will automatically publish when backporting changes to previous branches. This release also introduces minor style enhancements to the sidebar and homepage.
You can read more about all notable changes here.
How to test this PR
Clone this PR. For more information, see Cloning pull requests locally.
Enter the docs folder, and run:
Open http://localhost:5500 with your favorite browser. The doc should render without errors, and the version should be Sphinx Theme version (see the footer) must be
1.7.x
: