Merge pull request #377 from scylladb/dk/dont-panic-on-unknown-errror

Don't panic on unknown error
scylladb · Dec 20, 2024 · 3785839 · 3785839
2 parents e12494d + eb9141c
commit 3785839
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/errors.go b/errors.go
@@ -197,6 +197,10 @@ type RequestErrCASWriteUnknown struct {
 	BlockFor    int
 }
 
+type UnknownServerError struct {
+	errorFrame
+}
+
 type OpType uint8
 
 const (

diff --git a/frame.go b/frame.go
@@ -729,7 +729,9 @@ func (f *framer) parseErrorFrame() frame {
 			res.RejectedByCoordinator = f.readByte() != 0
 			return res
 		} else {
-			panic(fmt.Errorf("unknown error code: 0x%x", errD.code))
+			return &UnknownServerError{
+				errorFrame: errD,
+			}
 		}
 	}
 }

diff --git a/frame_test.go b/frame_test.go
@@ -25,8 +25,6 @@ func TestFuzzBugs(t *testing.T) {
 			"0000000"),
 		[]byte("\x82\xe600\x00\x00\x00\x000"),
 		[]byte("\x8200\b\x00\x00\x00\b0\x00\x00\x00\x040000"),
-		[]byte("\x8200\x00\x00\x00\x00\x100\x00\x00\x12\x00\x00\x0000000" +
-			"00000"),
 		[]byte("\x83000\b\x00\x00\x00\x14\x00\x00\x00\x020000000" +
 			"000000000"),
 		[]byte("\x83000\b\x00\x00\x000\x00\x00\x00\x04\x00\x1000000" +