Skip to content

Commit

Permalink
Make integration.sh not fail when compose up succeeded (#190)
Browse files Browse the repository at this point in the history
The change added in #188 not only
prints out the logs if container is unhealthy but also exits and manage to
not run the tests when there is nothing wrong with the containers.

This commit fixes incorrect behavior in case all containers are healthy and only
exits if one of the containers is unhealthy.
  • Loading branch information
dkropachev authored Jun 4, 2024
1 parent b7ff129 commit 6663620
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion integration.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function scylla_up() {

echo "==> Running Scylla ${SCYLLA_IMAGE}"
docker pull ${SCYLLA_IMAGE}
docker compose up -d --wait || docker compose ps --format json | jq -M 'select(.Health == "unhealthy") | .Service' | xargs docker compose logs && exit 1
docker compose up -d --wait || ( docker compose ps --format json | jq -M 'select(.Health == "unhealthy") | .Service' | xargs docker compose logs; exit 1 )
}

function scylla_down() {
Expand Down

0 comments on commit 6663620

Please sign in to comment.