-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Print out logs of failed container" #189
Conversation
Please add a reason for reverting a commit in the revert commit message. |
Done, sorry for merging that without being 100% sure that it is right and creating this whole situation |
No worries - this is not the issue at all. The issue is that it'd be great to know why we reverted a commit. |
This change not only prints out the logs if container is unhealthy but also exits and manage to not run the tests when there is nothing wrong with the containers.
d725620
to
95fb704
Compare
I added more detailed commit message |
@sylwiaszunejko , @mykaul, i should have kept that PR as draft, sorry. Let's better merge this one, it will fix the issue but keep printing logs on error |
@dkropachev I think it would be better to first merge this, then merge #187 and when the CI will be fixed we could add extra logging, because now CI on #190 won't pass |
But it won't pass because test is running on an image that don't support tablets:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but maybe we should merge #190 instead
And it's not going to be needed when 6.0 comes out (soon! soon!) |
Reverts #188
This change not only prints out the logs if container is unhealthy but also exits and manage to not run the tests when there is nothing wrong with the containers.