Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ring and ringDescriber #373

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Conversation

sylwiaszunejko
Copy link
Collaborator

Previously we had two separate structs to store hosts data.

This PR merges both of them and additionally does some refactoring like removing unnecessary methods/structs.

@sylwiaszunejko
Copy link
Collaborator Author

@dkropachev This is my draft PR with change you suggested. I would also consider changing some names: e.g. GetHosts() to something like GetHostsFromSystem() to make it clear when we are querying database and when we are getting cached hosts info like in allHosts() and currentHosts() (btw these names are also pretty random, why not getHostsList/Map?). I don't know how much change can we do to be honest. And I am not sure now if this is a good idea to do such big refactoring. Do we plan on merging upstream regularly? Because it would be harder probably. Are we ok with that?

@sylwiaszunejko
Copy link
Collaborator Author

@dkropachev could you take a look, please?

@dkropachev
Copy link
Collaborator

@dkropachev This is my draft PR with change you suggested. I would also consider changing some names: e.g. GetHosts() to something like GetHostsFromSystem() to make it clear when we are querying database and when we are getting cached hosts info like in allHosts() and currentHosts() (btw these names are also pretty random, why not getHostsList/Map?). I don't know how much change can we do to be honest. And I am not sure now if this is a good idea to do such big refactoring. Do we plan on merging upstream regularly? Because it would be harder probably. Are we ok with that?

It looks great, changing names is not s problem.
If you want - do it.
We can try to merge it to upstream to test waters, they are pretty active these days.

dkropachev
dkropachev previously approved these changes Dec 13, 2024
@dkropachev dkropachev merged commit e12494d into scylladb:master Dec 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants