Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ScyllaSniProxyTest tests to wait before checking on events API calls #359

Conversation

dkropachev
Copy link
Collaborator

Closes #358

ScyllaSniProxyTest tests creates a table and right away check of listener APIs.
Since listener API is called asynchronously it can fail.

@dkropachev dkropachev linked an issue Oct 8, 2024 that may be closed by this pull request
@dkropachev dkropachev requested a review from Bouncheck October 8, 2024 11:02
@dkropachev dkropachev self-assigned this Oct 8, 2024
@dkropachev dkropachev marked this pull request as ready for review October 8, 2024 11:02
calls

ScyllaSniProxyTest tests creates a table and right away check of
listener APIs.
Since listener API is called asynchronously it can fail.
@dkropachev dkropachev force-pushed the 358-3x-scyllasniproxytest-tests-are-failing-time-to-time branch from 97fc95f to 6b0d045 Compare October 8, 2024 11:06
Copy link
Collaborator

@Bouncheck Bouncheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could be done using Mockito but since there are atMost(n) checks we would need to wait full time anyway.

@dkropachev dkropachev merged commit 701b745 into scylla-3.x Oct 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: ScyllaSniProxyTest tests are failing time to time
2 participants