3.x: Add config for allowing zero-token nodes #400
Merged
+308
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouncheck
force-pushed
the
scylla-3.x-zero-token-ITs-v2
branch
from
e54498a to
25e4465
Compare
|
Made another version with different approach according to suggestions. @dkropachev we can choose which one to proceed with. |
Bouncheck
force-pushed
the
scylla-3.x-zero-token-ITs-v2
branch
4 times, most recently
from
b49eca4 to
de16bb0
Compare
Bouncheck
changed the title
Bouncheck
force-pushed
the
scylla-3.x-zero-token-ITs-v2
branch
from
de16bb0 to
6458a1c
Compare
Adds an option that controls if `system.peers` rows without tokens should be considered valid. Enabling this option will allow discovering zero-token peers with extended_peer_check enabled (it is enabled by default). Adds ZeroTokenNodesIT that verifies the driver behavior. It also contains some test methods relating to zero-token DCs. The special driver behavior for arbiter DCs is not yet fully decided so those methods can change in the future.
dkropachev
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option that controls if
system.peersrows without tokens shouldbe considered valid. Enabling this option will allow discovering zero-token
peers with extended_peer_check enabled (it is enabled by default).
Adds ZeroTokenNodesIT that verifies the driver behavior. It also contains
some test methods relating to zero-token DCs. The special driver behavior for
arbiter DCs is not yet fully decided so those methods can change in the future.