Fix table compression #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently setting table compression fails with `Missing sub-option 'sstable_compression' for the 'compression' option.`. This is due to Cassandra using now 'class' sub-option and Scylla using 'sstable_compression'. Resolved by calling with customized 'withOption' instead of directly 'withCompression'. Upgrades snappy to 1.1.10.5 . This technically also requires upping the driver version to the one using snappy 1.1.10.5 .
|
No issues observed when running with LZ4, Deflate, Snappy and no table compression. No issues observed with Snappy protocol compression. |
dkropachev
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently setting table compression fails with
Missing sub-option 'sstable_compression' for the 'compression' option.. This is due to Cassandra using now 'class' sub-option and Scylla using 'sstable_compression'. Resolved by calling with customized 'withOption' instead of directly 'withCompression'.Upgrades snappy to 1.1.10.5. This technically also requires upping the driver version to the one using snappy 1.1.10.5.