Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 6.2] ccmlib/node: check both pending and active tasks when waiting for compactions #614

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

cezarmoise
Copy link
Contributor

Currently, when using wait_for_compactions, only pending tasks are considered. If there are active compaction tasks, the function will return anyway and this causes flakyness in tests, as sometimes the active task finishes before the next operation, but sometimes it doesn't.

  • Rename Node._parse_pending_tasks to Node._parse_tasks
  • Count all tasks, pending and active
  • Allow searching for tasks based on only keyspace
  • Update and refactor test to allow more varied cases

closes: #610
refs: https://github.com/scylladb/scylla-dtest/issues/4702

cherry-picked ee7ebef^..4b1ac16

@cezarmoise cezarmoise requested a review from fruch September 24, 2024 08:44
@cezarmoise cezarmoise self-assigned this Sep 24, 2024
@cezarmoise cezarmoise changed the base branch from next to next-6.2 September 24, 2024 08:47
…pactions

- Rename Node._parse_pending_tasks to Node._parse_tasks
- Count all tasks, pending and active
- Allow searching for tasks based on only keyspace
- Update and refactor test to allow more varied cases
@fruch fruch merged commit b67f44a into scylladb:next-6.2 Sep 24, 2024
4 checks passed
@cezarmoise cezarmoise deleted the pr-611-next-6.2 branch September 24, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Node._parse_pending_tasks and Node.wait_for_compactions to account for tasks in progress
2 participants