[Backport 2024.1] ccmlib/node: check both pending and active tasks when waiting for compactions #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR checks fail with
|
actions/upload-artifact@v2 is deprecated and can't be used anymore
…pactions - Rename Node._parse_pending_tasks to Node._parse_tasks - Count all tasks, pending and active - Allow searching for tasks based on only keyspace - Update and refactor test to allow more varied cases
fruch
force-pushed
the
pr-611-next-2024.1
branch
from
7fd1a1a to
ecdd75c
Compare
|
branch-2024.1 was missing a fix to the CI, adding it here. |
|
now it's one broken test, that try to run the latest scylla, and expect it to have JMX it's a series of change not going to backport, on next backports we should disable that test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using
wait_for_compactions, only pending tasks are considered. If there are active compaction tasks, the function will return anyway and this causes flakyness in tests, as sometimes the active task finishes before the next operation, but sometimes it doesn't.closes: #610
refs: https://github.com/scylladb/scylla-dtest/issues/4702
cherry-picked ee7ebef^..4b1ac16