scylla_node: add support to run scylla types tool
#621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pehala
reviewed
Oct 17, 2024
ccmlib/scylla_node.py
Outdated
| Raises: subprocess.CalledProcessError if scylla-types serialize returns a non-zero exit code. | ||
|
|
||
| """ | ||
| if len(values) > len(types): |
There was a problem hiding this comment.
What about using a dict? That way it cannot get mismatched
There was a problem hiding this comment.
@pehala We cannot use a dict because we need to allow duplicate keys.
I tried using List[Tuple[str, str]], but if prefixable_compounds is set to True, the length of values can be less than the length of types and the existing code seemed more user friendly for such cases. So, I have left it as it is.
lkshminarayanan
force-pushed
the
implement-shardof
branch
from
226bd0b to
448cc7e
Compare
denesb
requested changes
Oct 18, 2024
lkshminarayanan
force-pushed
the
implement-shardof
branch
from
448cc7e to
9dc7503
Compare
|
Changelog V2 :
|
lkshminarayanan
changed the title
types tool and actionsscylla types tool
pehala
reviewed
Oct 19, 2024
denesb
requested changes
Oct 21, 2024
lkshminarayanan
force-pushed
the
implement-shardof
branch
3 times, most recently
from
e6cace6 to
321d730
Compare
tchaikov
reviewed
Oct 21, 2024
lkshminarayanan
force-pushed
the
implement-shardof
branch
2 times, most recently
from
5bf8d76 to
2c18d02
Compare
pehala
approved these changes
Oct 21, 2024
This PR implements the `run_scylla_types` method in the ScyllaNode class to run the `types` tool. Also added a new class, ScyllaType to allow callers to define the type that is being sent to the types tool. This is required by scylladb/scylla-dtest#5093 to deduce shards of the partition keys. Refs scylladb/scylladb#18011 Signed-off-by: Lakshmi Narayanan Sreethar <[email protected]>
lkshminarayanan
force-pushed
the
implement-shardof
branch
from
2c18d02 to
aed75ab
Compare
denesb
approved these changes
Oct 21, 2024
|
@fruch please review/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
run_scylla_typesmethod in the ScyllaNode classto run the
typestool. Also added a new class, ScyllaKeyType to allowcallers to define the key type that is being sent to the types tool.
This is required by scylladb/scylla-dtest#5093 to deduce shards of the
partition keys.
Refs scylladb/scylladb#18011