scylla_conifgure.py: skip construct data volume on dev_instance_type

[syuu1228]

Since dev_instance_type does not have local SSD, we should skip running scylla_create_devices.

Fixes #551

[syuu1228]

jenkins test passed: https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/next-machine-image/384/

[fruch]

@syuu1228 @yaronkaikov

there is a specific test for t3.micro

and it seems to be running just fine, on master and on 2024.2:
https://argus.scylladb.com/tests/scylla-cluster-tests/8885cca7-19dd-478b-88fd-4a0f3347ddf4

I would recommend checking out why it's not catching the issue encounter, and adapt the test to catch it.

[syuu1228]

I realized that extra disks may attached to the dev instance (at least SCT test does it), changed the code to handle it: https://github.com/scylladb/scylla-machine-image/compare/39213f94e52694846b218ff0ba6cf6c629bf60f9..25e13c4f217535ee9b60e7345aafb64137506c5a
And testing it now.

[syuu1228]

I realized that extra disks may attached to the dev instance (at least SCT test does it), changed the code to handle it: https://github.com/scylladb/scylla-machine-image/compare/39213f94e52694846b218ff0ba6cf6c629bf60f9..25e13c4f217535ee9b60e7345aafb64137506c5a
And testing it now.

Test passed.
https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/next-machine-image/385/
https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/artifacts/job/artifacts-ami-t3_micro-test/13/

[fruch]

Maybe there should be a test that shows scylla working with adding an extra disk ?

As in the original failure in issue this PR is fixing ?

[roydahan]

@fruch IIUC the the artifact test we have in SCT, it must have an extra disk:

data_volume_disk_num: 1  # t3.micro doesn't include any local volumes (outside of root), so an additional disk is required for scylla

Which I assumed was a requirement for it to work.

@syuu1228
What is the current claimed problem? that it doesn't work without extra disk?