packer/build_images.sh: get version and release values from pipline #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsfreitas
previously approved these changes
Dec 3, 2024
Annamikhlin
reviewed
Dec 3, 2024
yaronkaikov
force-pushed
the
getscyllaversionandrelease
branch
from
1675f57 to
b59fce3
Compare
Annamikhlin
reviewed
Dec 3, 2024
packer/build_image.sh
Outdated
| if [ -z "$TARGET" ]; then | ||
| echo "Missing --target parameter. Please specify target cloud (aws/gce/azure)" | ||
| exit 1 | ||
| fi | ||
|
|
||
| SSH_USERNAME=ubuntu | ||
|
|
||
| SCYLLA_FULL_VERSION="$VERSION-$SCYLLA_RELEASE" | ||
| SCYLLA_MACHINE_IMAGE_VERSION="$VERSION-$SCYLLA_MACHINE_IMAGE_RELEASE" | ||
|
|
||
| if [ $LOCALDEB -eq 1 ]; then | ||
| INSTALL_ARGS="$INSTALL_ARGS --localdeb" |
There was a problem hiding this comment.
BTW, what about the option of --localdeb I'm not sure it will work now. Actually I'm not sure we are using it
There was a problem hiding this comment.
We are not using it for sure. it's for someone who builds locally and then needs an AMI
We can obliterate it as we have today BYO can do that instead, WDYT?
There was a problem hiding this comment.
Yes, I think BYO it is a good alternative.
There was a problem hiding this comment.
I will add another commit to remove it
related to changes in scylladb/scylla-pkg#4635, modifying the script to get `version` and `release` values from the pipeline to remove the constrain between dpackager OS and image OS Should be merged together with scylladb/scylla-pkg#4635
yaronkaikov
force-pushed
the
getscyllaversionandrelease
branch
from
b59fce3 to
ee479de
Compare
|
@Annamikhlin Added another commit with the cleanup |
@Annamikhlin let me know if you have any more comments |
Annamikhlin
reviewed
Dec 3, 2024
packer/build_image.sh
Outdated
| @@ -36,19 +34,13 @@ print_usage() { | |||
| echo " --ec2-instance-type Set EC2 instance type to use while building the AMI. If empty will use defaults per architecture" | |||
| exit 1 | |||
| } | |||
| LOCALDEB=0 | |||
| DOWNLOAD_ONLY=0 | |||
There was a problem hiding this comment.
DOWNLOAD_ONLY - can be removed as well
Annamikhlin
previously approved these changes
Dec 3, 2024
Since both option are not really in use anymore, and in case we need to build a custom image we can do it using BYO
yaronkaikov
force-pushed
the
getscyllaversionandrelease
branch
from
7d6d53a to
264dd07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to changes in https://github.com/scylladb/scylla-pkg/pull/4635, modifying the script to get
versionandreleasevalues from the pipeline to remove the constrain between dpackager OS and image OSShould be merged with https://github.com/scylladb/scylla-pkg/pull/4635
Testing