fix: use Split instead of SplitN

scylladb · Dec 17, 2024 · 18feedb · 18feedb
1 parent c9f5e9a
commit 18feedb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/pkg/cloudmeta/gcp.go b/pkg/cloudmeta/gcp.go
@@ -53,7 +53,7 @@ func (gcp *gcpMetadata) getMachineType(ctx context.Context) (string, error) {
 func parseMachineTypeResponse(resp string) (string, error) {
 	errUnexpectedFormat := errors.Errorf("unexpected machineType response format: %s", resp)
 
-	parts := strings.SplitN(resp, "/", 4)
+	parts := strings.Split(resp, "/")
 	if len(parts) != 4 {
 		return "", errUnexpectedFormat
 	}

diff --git a/pkg/cloudmeta/gcp_test.go b/pkg/cloudmeta/gcp_test.go
@@ -26,6 +26,13 @@ func TestParseMachineTypeResponse(t *testing.T) {
 			expectedErr: true,
 			expected:    "",
 		},
+		{
+			name:                "new response part is added after machineTypes part",
+			machineTypeResponse: "projects/project1/machineTypes/machineType1/zones/zone1",
+
+			expectedErr: true,
+			expected:    "",
+		},
 		{
 			name:                "parts are mixed up",
 			machineTypeResponse: "machineTypes/machineType1/projects/project1",