fix(managerclient): progress, round success % down and error % up

This approach is safer than printing 0% error when only a fraction of a task has failed.

Fixes #3581

pkg/managerclient/utils.go

@@ -79,11 +79,9 @@ func FormatRepairProgress(total, success, failed int64) string {
 	if total == 0 {
 		return "-"
 	}
-	out := fmt.Sprintf("%.f%%",
-		float64(success)*100/float64(total),
-	)
+	out := fmt.Sprintf("%.f%%", math.Floor(float64(success)*100/float64(total)))
 	if failed > 0 {
-		out += fmt.Sprintf("/%.f%%", float64(failed)*100/float64(total))
+		out += fmt.Sprintf("/%.f%%", math.Ceil(float64(failed)*100/float64(total)))
 	}
 	return out
 }
@@ -128,11 +126,9 @@ func FormatUploadProgress(size, uploaded, skipped, failed int64) string {
 		return "100%"
 	}
 	transferred := uploaded + skipped
-	out := fmt.Sprintf("%d%%",
-		transferred*100/size,
-	)
+	out := fmt.Sprintf("%.f%%", math.Floor(float64(transferred)*100/float64(size)))
 	if failed > 0 {
-		out += fmt.Sprintf("/%d%%", failed*100/size)
+		out += fmt.Sprintf("/%.f%%", math.Ceil(float64(failed)*100/float64(size)))
 	}
 	return out
 }
@@ -142,10 +138,10 @@ func FormatRestoreProgress(size, restored, downloaded, failed int64) string {
 	if size == 0 {
 		return "100%"
 	}
-	out := fmt.Sprintf("%d%%", restored*100/size)
-	out += fmt.Sprintf(" | %d%%", downloaded*100/size)
+	out := fmt.Sprintf("%.f%%", math.Floor(float64(restored)*100/float64(size)))
+	out += fmt.Sprintf(" | %.f%%", math.Floor(float64(downloaded)*100/float64(size)))
 	if failed > 0 {
-		out += fmt.Sprintf(" / failed: %d%%", failed*100/size)
+		out += fmt.Sprintf(" / failed: %.f%%", math.Ceil(float64(failed)*100/float64(size)))
 	}
 	return out
 }

pkg/managerclient/utils_test.go

@@ -264,14 +264,14 @@ func TestFormatRepairProgress(t *testing.T) {
 			Total:   1536,
 			Success: 1228,
 			Failed:  308,
-			Golden:  "80%/20%",
+			Golden:  "79%/21%",
 		},
 		{
 			Name:    "partial failure not-complete",
 			Total:   1536,
 			Success: 1229,
 			Failed:  154,
-			Golden:  "80%/10%",
+			Golden:  "80%/11%",
 		},
 	}