Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #3687

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Update documentation #3687

merged 4 commits into from
Jan 17, 2024

Conversation

Michal-Leszczynski
Copy link
Collaborator

This PR fixes a bunch of documentation related issues.

Fixes #3684
Fixes #3681
Fixes #3661
Fixes #3663

@Michal-Leszczynski Michal-Leszczynski added the documentation Improvements or additions to documentation label Jan 12, 2024
Copy link
Collaborator

@tzach tzach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Michal-Leszczynski Michal-Leszczynski marked this pull request as ready for review January 15, 2024 13:57
@Michal-Leszczynski
Copy link
Collaborator Author

@annastuchlik could you take a look at this PR?

Copy link
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only added one minor suggestion.
Another one is to add the note in a separate file in the _common folder and add it in appropriate places using the include directive, for example:
.. include:: _common/operator-reference.rst

This update is recommended but not critical.

@Michal-Leszczynski
Copy link
Collaborator Author

The problem with using include for linking to operator docs is that there are separate pages for repair/backup and for restore. So for now I will keep the links directly in the code, so that they don't get confused, but it can be changed later on.

@Michal-Leszczynski Michal-Leszczynski merged commit 8157d6e into master Jan 17, 2024
42 checks passed
@Michal-Leszczynski Michal-Leszczynski deleted the ml/update-docs branch January 17, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
4 participants