Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore schema workaround #3697

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Conversation

Michal-Leszczynski
Copy link
Collaborator

@Michal-Leszczynski Michal-Leszczynski commented Jan 24, 2024

This PR adds a validation of consistent_cluster_management and Scylla version before restoring schema (more info in #3662). It also documents a workaround for newer Scylla versions with consistent_cluster_management: true.

@Michal-Leszczynski Michal-Leszczynski force-pushed the ml/restore-workaround-docs branch from eedbf52 to 5100e4e Compare January 24, 2024 12:44
@Michal-Leszczynski Michal-Leszczynski force-pushed the ml/restore-workaround-docs branch from 5100e4e to dbc72c9 Compare January 24, 2024 13:22
@Michal-Leszczynski
Copy link
Collaborator Author

In the logs of integration-tests (scylla:5.4.1, IPV6, true) / Test restore schema we can see that:

service_restore_integration_test.go:1429: init target: restore into cluster with given ScyllaDB version and consistent_cluster_management is not supported. See https://manager.docs.scylladb.com/stable/restore/restore-schema.html for a workaround.

@Michal-Leszczynski
Copy link
Collaborator Author

This PR contains workaround documentation for bot Scylla 5.4 and 2024, even though the latter one is not released yet. Is this ok? It also adds Scylla 5.4 into restore compatibility matrix. Should Scylla 2024 be added there as well?

@Michal-Leszczynski Michal-Leszczynski marked this pull request as ready for review January 25, 2024 12:17
@Michal-Leszczynski Michal-Leszczynski added documentation Improvements or additions to documentation restore labels Jan 25, 2024
@Michal-Leszczynski
Copy link
Collaborator Author

@karol-kokoszka @annastuchlik @tzach could you take a look?

Copy link
Collaborator

@karol-kokoszka karol-kokoszka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@Michal-Leszczynski
Copy link
Collaborator Author

@tzach @annastuchlik could you please take a look?

@Michal-Leszczynski Michal-Leszczynski force-pushed the ml/restore-workaround-docs branch from a42219a to 1e75e01 Compare February 21, 2024 16:08
Copy link
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (docs)

@Michal-Leszczynski Michal-Leszczynski merged commit 69de42c into master Feb 22, 2024
20 of 22 checks passed
@Michal-Leszczynski Michal-Leszczynski deleted the ml/restore-workaround-docs branch February 22, 2024 13:35
@karol-kokoszka karol-kokoszka mentioned this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation restore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants