Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair: fix repair --host filtering #3737

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

Michal-Leszczynski
Copy link
Collaborator

Fixes #3736

Full replication might mask some errors and is not the usual cluster setup.
@Michal-Leszczynski Michal-Leszczynski force-pushed the ml/fix-repair-host-filtering branch from e5620c4 to cbe3110 Compare March 6, 2024 12:13
@Michal-Leszczynski Michal-Leszczynski marked this pull request as ready for review March 6, 2024 12:59
@Michal-Leszczynski
Copy link
Collaborator Author

The following test was failing after changing repair test setup and passed after applying the fix:

=== RUN   TestServiceRepairIntegration/repair_host
--- When: run repair
--- Then: repair is running
13:04:25.232	INFO	Start generating target	{"task": "87f5bbe7-4483-4304-998c-ca04d95f3baf", "run": "acf1dfb4-dbb1-11ee-9625-0892040e83bb"}
13:04:25.279	INFO	End generating target	{"task": "87f5bbe7-4483-4304-998c-ca04d95f3baf", "run": "acf1dfb4-dbb1-11ee-9625-0892040e83bb", "error": "create repair plan: no replicas to repair"}
    service_repair_integration_test.go:1242: timeout 1m0s
    --- FAIL: TestServiceRepairIntegration/repair_host (60.01s)

@Michal-Leszczynski
Copy link
Collaborator Author

@karol-kokoszka why do we only test 2024.1.0.rc3 on PRs? I know that other versions are tested on push to master, but I think that it would be useful to see results of those tests before merging PRs to master.

@karol-kokoszka
Copy link
Collaborator

@karol-kokoszka why do we only test 2024.1.0.rc3 on PRs? I know that other versions are tested on push to master, but I think that it would be useful to see results of those tests before merging PRs to master

There were too many of these checks on a single PR. They are part of merging to master branch now.
You can still execute these tests locally.

@Michal-Leszczynski
Copy link
Collaborator Author

But maybe it would be better to check different Scylla versions in favor of checking the same Scylla version with different IP_FAMILY?

@karol-kokoszka
Copy link
Collaborator

Let's keep it as a check for the latest commercial release of Scylla that includes all variants.
Other version let be checked on master branch.

@Michal-Leszczynski
Copy link
Collaborator Author

Ok, btw this PR is ready for review

@Michal-Leszczynski Michal-Leszczynski force-pushed the ml/fix-repair-host-filtering branch from 2bca285 to 0311cbc Compare March 6, 2024 14:30
@Michal-Leszczynski
Copy link
Collaborator Author

@karol-kokoszka, actually, just pushed a small fix for a single node cluster, now it should be good to go.

Copy link
Collaborator

@karol-kokoszka karol-kokoszka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@karol-kokoszka karol-kokoszka merged commit 3ecb629 into master Mar 6, 2024
19 of 21 checks passed
@karol-kokoszka karol-kokoszka deleted the ml/fix-repair-host-filtering branch March 6, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect repair --host node filtering
2 participants