Close client and session #3777
Merged
Close client and session #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Michal-Leszczynski It's failing the repair. I need to merge closing client on session creation. Rest will be updated in next release. |
|
@karol-kokoszka I'm trying to understand why that's the case. Maybe it discovered some unrelated bug. Failing repair test pauses ongoing repair 4 times and it fails with fifth repair returning session closed error: 2024-03-29T12:27:53.5782633Z --- When: run second repair with context cancel
2024-03-29T12:27:54.0160885Z --- When: run third repair with context cancel
2024-03-29T12:27:54.4337332Z --- When: run fourth repair with context cancel
2024-03-29T12:27:54.8595888Z --- When: run fifth repair till it finishes
2024-03-29T12:27:55.2806464Z service_repair_integration_test.go:1074: Repair failed: get cluster views: session has been closedI'm wondering if we actually somehow cache those sessions? What could be the reason for that? |
Michal-Leszczynski
force-pushed
the
ml/close-client-and-session
branch
from
fb49738 to
1640dcd
Compare
|
@karol-kokoszka It looks like the cause of the error was the fact that repair tests cached CQL session. |
|
please resolve the conflicts |
Michal-Leszczynski
force-pushed
the
ml/close-client-and-session
branch
from
1640dcd to
b8ac58c
Compare
|
@karol-kokoszka conflicts are resolved! |
karol-kokoszka
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3769