Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve restore schema topology requirement #3783

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

Michal-Leszczynski
Copy link
Collaborator

Fixes #3782

@Michal-Leszczynski Michal-Leszczynski marked this pull request as ready for review April 3, 2024 15:40
@Michal-Leszczynski
Copy link
Collaborator Author

@tzach @karol-kokoszka @annastuchlik This PR clarifies restore destination cluster topology requirements for both restoring schema and user data. Don't mind the test failures as they are already fixed on master and aren't related to this PR.

@Michal-Leszczynski
Copy link
Collaborator Author

Ping @tzach @karol-kokoszka @annastuchlik

Copy link
Collaborator

@karol-kokoszka karol-kokoszka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Michal-Leszczynski Michal-Leszczynski added documentation Improvements or additions to documentation restore labels Apr 15, 2024
@annastuchlik
Copy link
Collaborator

@Michal-Leszczynski I've added some suggestions on how to improve the wording.
However, I would recommend one more change: add the information to the description rather than a note (|on both pages).
If it's added as a note, there will be multiple boxes with notes and warnings, which makes the docs hard to process.
image

@Michal-Leszczynski Michal-Leszczynski force-pushed the ml/restore-schema-any-topology-docs branch from 67cf7a7 to b193270 Compare April 17, 2024 12:15
@Michal-Leszczynski
Copy link
Collaborator Author

@annastuchlik I removed notes as requested. Can you take a look?

Copy link
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@Michal-Leszczynski Michal-Leszczynski merged commit fcce87d into master Apr 19, 2024
52 of 57 checks passed
@Michal-Leszczynski Michal-Leszczynski deleted the ml/restore-schema-any-topology-docs branch April 19, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation restore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imporve restore schema topology requirement
3 participants