Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(managerclient): update manager deps to point to the commit from master #4057

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

karol-kokoszka
Copy link
Collaborator


Please make sure that:

  • Code is split to commits that address a single change
  • Commit messages are informative
  • Commit titles have module prefix
  • Commit titles have issue nr. suffix

@Michal-Leszczynski
Copy link
Collaborator

@karol-kokoszka what is this PR about? Did we have some problems with 3.3.3 release which included the package split? I see that you already merged 385fb1b to master, so why is this needed?

@karol-kokoszka
Copy link
Collaborator Author

@Michal-Leszczynski managerclient module was poiting to the github.com/scylladb/scylla-manager/v3/pkg/utils dependency with commit taken from the branch different than master.
One of the scylla-cloud dev faced an issue because of that trying to build siren on GH actions env.

@Michal-Leszczynski
Copy link
Collaborator

So does it mean that we have a regression in SM 3.3.3?

@karol-kokoszka
Copy link
Collaborator Author

No, managerclient is independent from 3.3.3. We are not tagging (yet) the releases of managerclient.

@karol-kokoszka karol-kokoszka merged commit 5048128 into master Oct 3, 2024
49 of 51 checks passed
@karol-kokoszka karol-kokoszka deleted the fix_deps_managerclient branch October 3, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants