Restore improvement: compaction #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michal-Leszczynski
force-pushed
the
ml/restore-compaction
branch
from
6730919 to
dec55d5
Compare
Michal-Leszczynski
force-pushed
the
ml/restore-compaction
branch
from
dec55d5 to
85be062
Compare
|
@karol-kokoszka This PR is ready for review! |
This commit add TestRestoreTablesPreparationIntegration. Its purpose is to check setup changes performed by SM during restore data stage. Right now it validates tombstone_gc mode and compaction, but it can be easily extended in the future. Test scenario: - Run restore - hang on restore data stage - Validate setup - Pause restore - Validate setup - Resume restore - hang on restore data stage - Validate setup - Resume restore - wait for success - Validate setup - Validate restore success
…tegration This check isn't implemented correctly, as starting from 27b1d23, file names are not stored in the SM DB. It means that 'sfs' was always empty. Nevertheless, the partial upload check could still fail when 's3f' was empty as well. This test does not implement any breakpoint to ensure that backup is paused after transferring at least a single file (it just waits for the transfers to start). That's why this check was flaky and didn't do anything meaningful, so it is removed from the test.
Michal-Leszczynski
force-pushed
the
ml/restore-compaction
branch
from
f684643 to
63f1787
Compare
|
@karol-kokoszka I addressed the comments, could you take a look again? |
karol-kokoszka
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new boolean restore flag
--allow-compaction(false by default).When it's set to false, SM disables auto compactions on restored tables for the time of the restore and enables them back when its done.
Fixes #3953