Restore improvement: rate limit #4070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michal-Leszczynski
force-pushed
the
ml/restore-ratelimit
branch
from
001afe0 to
b60a232
Compare
As we want to add rate limit to restore, we should reuse the code already present in the backup pkg. This commit also makes functions generic.
It's useful for testing purposes.
This is the first step to control rate limit in the context of restore.
This commit requires changes in the usage of RcloneCopyPaths in restore pkg.
This commit allows user to control rclone server rate limit used during restore.
This commit requires changes in the usage of RcloneMoveDir in backup pkg.
…th rate limit This way this test also checks rate limit before and after backup. It also checks transfers before, in the middle, when paused, when resumed, and after restore. This commit also extends the test to change transfers and rate limit values when restore is paused, so that it validates that they are correctly re-set during restore data stage.
Michal-Leszczynski
force-pushed
the
ml/restore-ratelimit
branch
from
b60a232 to
45628fd
Compare
|
@karol-kokoszka This PR is ready for review! |
|
@Michal-Leszczynski Is it possible to give another commit name when you choose to "squash and merge" ? I see that there are plenty of "Restore improvement: transfers" etc commits on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way to control rate limit in the context of restore via new
--rate-limitrestore flag with default value 0 - meaning no rate limit at all.It borrows rate limit syntax from backup pkg for consistency - meaning that it's possible to specify rate limit per dc.
Fixes #3947