-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rclone: don't rely on cached bandwidth limit in configguard #4120
Conversation
Setting bandwidth limit should be handled by specific Rclone calls.
Example agent logs from
And after the change:
(changed bandwidth limit to 999M because otherwise we wouldn't see any log with bandwidth limit change, but that's expected) |
|
No luck with that - there is some chance that minio lagged when listing manifests just after their creation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@karol-kokoszka The PR is ready for review! |
@karol-kokoszka This PR is ready for review! Let's merge it and start the 3.4.1 release process. |
This PR fixes the way in which
configguard
checked if bandwidth limit should be updated.Previously it was updating bandwidth limit with each Rclone call, now it updates it only when it's changed.
This PR also removes unnecessary usages of
RcloneSetBandwidthLimit
, as handling bandwidth limit should be done by specific Rclone calls.Fixes #4119